Added power state to Hana Instance#3570
Added power state to Hana Instance#3570dsgouda merged 3 commits intoAzure:masterfrom PakDLiu:donaliu_addedPowerStateToHanaInstance
Conversation
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
| "type": "string", | ||
| "description": "Resource location" | ||
| }, | ||
| "powerState": { |
There was a problem hiding this comment.
This cannot be a top level resource property. Must be a part of the properties property
There was a problem hiding this comment.
Please check if this is how the service is consuming/returning the resource information
There was a problem hiding this comment.
I've just updated our API to move the power state. here is a sample:
{
"id": "/subscriptions/c5c14913-17c5-4bb7-a8d4-5fb40d0a4823/resourceGroups/rg10004/providers/Microsoft.HanaOnAzure/hanaInstances/westusbmiName",
"name": "westusbmiName",
"type": "Microsoft.HanaOnAzure/hanaInstances",
"location": "westus",
"tags": {
"owner": "alias4"
},
"properties": {
"hanaInstanceId": "2e30e358-7ceb-42d0-b7f4-cb7e41e1a8bc",
"powerState": "started",
"hardwareProfile": {
"hardwareType": "Cisco_UCS",
"hanaInstanceSize": "S72"
},
"networkProfile": {
"networkInterfaces": [
{
"ipAddress": "123.123.123.123"
}
],
"circuitId": "/subscriptions/c5c14913-17c5-4bb7-a8d4-5fb40d0a4823/resourceGroups/rg10004/providers/Microsoft.Network/expressRouteCircuits/westusbmiName"
},
"storageProfile": {
"nfsIpAddress": "123.123.123.124"
},
"osProfile": {
"computerName": "westusbmiName",
"osType": "SLES 12 SP2",
"version": "12 SP2"
}
}
}
There was a problem hiding this comment.
Looks good.
As a sidenote, it looks like powerstate could be an enum, you could simply use an x-ms-enum
There was a problem hiding this comment.
powerstate is an enum now
|
LGTM |
Co-authored-by: Ben Viglietta <benvi@ntdev.microsoft.com>
4 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger